[frontend] History tab top margin / spacing (#9568)#9621
Merged
ValentinBouzinFiligran merged 5 commits intomasterfrom Jan 20, 2025
Merged
[frontend] History tab top margin / spacing (#9568)#9621ValentinBouzinFiligran merged 5 commits intomasterfrom
ValentinBouzinFiligran merged 5 commits intomasterfrom
Conversation
ValentinBouzinFiligran
added
the
filigran team
ValentinBouzinFiligran
force-pushed
the
issue/9568
branch
from
76e53ba to
248dc19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9621 +/- ##
=======================================
Coverage 65.26% 65.26%
=======================================
Files 630 630
Lines 60244 60244
Branches 6760 6763 +3
=======================================
Hits 39319 39319
Misses 20925 20925 ☔ View full report in Codecov by Sentry. |
ValentinBouzinFiligran
force-pushed
the
issue/9568
branch
from
8df0442 to
8efeb97
Compare
CelineSebe
reviewed
Jan 17, 2025
| <div style={{ float: 'right' }}> | ||
| <SearchInput | ||
| variant="thin" | ||
| onSubmit={handleSearchEntity} |
Member
There was a problem hiding this comment.
Is it possible to set directly "setEntitySearchTerm(value)" there?
Member
Author
There was a problem hiding this comment.
I should write an anonymous function directly here and I don't find it great for readability
CelineSebe
reviewed
Jan 17, 2025
| key={`latest_history_skel_${i}`} | ||
| dense | ||
| divider | ||
| button={false} |
Member
There was a problem hiding this comment.
I think you can remove button={false}, it's deprecated
Member
|
Tested ✅ |
CelineSebe
approved these changes
Jan 17, 2025
Member
|
I found a pre-existing bug. When I write in the left search bar, the same input appears in the search bar on the right: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments